feat: pass end_exchange through to UiPathChatRuntime [JAR-9933]#1720
Open
andrewwan-uipath wants to merge 1 commit into
Open
feat: pass end_exchange through to UiPathChatRuntime [JAR-9933]#1720andrewwan-uipath wants to merge 1 commit into
andrewwan-uipath wants to merge 1 commit into
Conversation
github-actions
Bot
added
test:uipath-langchain
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the uipath CLI’s conversational execution wiring to honor the conversationalService.endExchange FPS property by passing end_exchange=ctx.end_exchange into UiPathChatRuntime, leveraging behavior introduced in uipath-runtime 0.12.0.
Changes:
- Pass
end_exchange=ctx.end_exchangewhen constructingUiPathChatRuntimein bothrunanddebugCLI flows. - Add CLI tests to validate default exchange-end emission and suppression when
endExchange=false. - Bump
uipath-runtimedependency to>=0.12.0, <0.13.0and increment package version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/uipath/src/uipath/_cli/cli_run.py | Passes ctx.end_exchange into UiPathChatRuntime so conversational end-exchange behavior can be controlled via FPS properties. |
| packages/uipath/src/uipath/_cli/cli_debug.py | Same end_exchange pass-through for the debug command’s conversational wrapper. |
| packages/uipath/tests/cli/test_run.py | Adds coverage verifying exchange-end event is emitted by default and skipped when endExchange=false. |
| packages/uipath/tests/cli/test_debug_chat.py | Adds coverage verifying end_exchange is forwarded into the UiPathChatRuntime constructor in debug. |
| packages/uipath/pyproject.toml | Updates package version and bumps uipath-runtime to the compatible range that includes endExchange support. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
effect. When false, the exchange-end event is skipped and the exchange stays open for a downstream consumer.